Ticket	Summary	Owner	Status	Type	Component	Priority	Effort	Importance
#1766	UNPLANED_APP_COMMONS_TEST_FIXING	george	closed	unplanned_task	uncategorized	major
Reported by mira, 3 years ago.
Description	Unplaned task for fixing the tests in main.app.commons. UNPLANED_APP_COMMONS_TEST_FIXING
Analysis_owners	velizar
Analysis_reviewers	dido
Analysis_score	3
Design_owners	velizar,george
Design_reviewers	kyli
Design_score	2
Imp._score	0
Test_score	0

Analysis

Overview

All unit tests in main.app.commons that are not working should be fixed.

Task requirements

• Move the tests, which are in wrong package, to their correct package.
• Delete duplicate tests.
• Fix all remaining tests.

Task result

All unit tests in main.app.commons should be working.

Implementation idea

Debug the tests that fail and correct the errors.

How to demo

Design

• For the test testContentView in class ContentViewTest - use the property contentElement() from the frameView to get the image instead of the property element(), provide ResourceChangeManager for the resources in the test.
• For all the tests in AppLogicSystemTest - move the class to package org.sophie2.author and start the required modules in fillDepenedencies() method.
• For the test testCloseApp in AppLogicSystemTest - check if the project is started through the fakeModuleRegistry, if so leaving the confirm dialog for exit with YES will cause System.exit(0) and the method will never return.

Implementation

^{(Describe and link the implementation results here (from the wiki or the repository).)}

Testing

^{(Place the testing results here.)}

Comments

^{(Write comments for this or later revisions here.)}