PAGE_PREVIEW_PALETTE_R0

[Astea]

wiki page: PAGE_PREVIEW_PALETTE_R0 - effort: 1.5d

[kyli]

4p. It's OK.

[deyan]

Batch update from file newimport.csv

[deyan]

Should we return this to analysis ok?

[danvisel]

Reworking analysis with Sveto.

[danvisel]

This analysis is ready to be reviewed. Time = 4h.

[dido]

If the thumbs are with fixed size for this revision, they should remain the aspect ratio of the page and fill the remaining space in the thumb with flat colour. It will be nice if its the same as page background colour or if the page background is different than flat colour we could use black or white.
analysis review 4p (1h)

[sveto]

design took 7.5h

[pap]

• There are good ideas in the desin but there are things that are not good
• I think that the PagePreviewPaletteCellRenderer is not necessary. You can use te render() method of the ListPaletteItem
• You should use LogicR3 about the actions that the palette performs.
• The latter gives you the ability to easily write tests, which are obligatory for designs.

[sveto]

(6h)

[pap]

• I think the design is better now, but there are things that I want to note.
• From the tests given I get the idea that page deletion is not done with the use of MVCR3 events. It is better if you use them for such things.
• It is good to make sure that you cannot delete pages when a book is not editable(in preview mode)
• You should mention all major changes that you do in your design. This means that the changes to the ListPalette should be described too.
• To make the above clearer : Design part of a wiki page includes all the changes to the project, not only the ones that are to the particular task.
• Make sure that in the implementation section you mention what went different from what was described in the design.
• Good luck.

[sveto]

(17.5h)

[pap]

• There is unused code that you havent cleared out.
• You had some methods with missing javadoc
• Ids is not a nice name. EventIds is better although even better may exist.
• You have lots of final properties and that is bad.
• It is better to use some auto properties in some places
• The multiple selection of items should be available for all ListPalettes. It is not nice to do such a separete solution for each palette. You may just leave it with single selection for now.
• Having a separate page work area for each item makes the application very slow.
• Perhaps you may have a single page work area and make the thumbnails display only an image that is creted in the synchronizing property.

[sveto]

(9h)

[meddle]

I'll have to fail it because nothing can be saved with the persistence now and when you add non-text frames some times the app crashes :(

2.5p (70m)

[pap]

• Why did you use ResourceH#get(key) instead of BookH#getPages(); Why didn't you fix it???
• Use BookViewOptions when possible. It is much lceaner than "author".equals ......
• The buttons for adding pages were visible and enabled for preview mode books.
• There are problems with the refreshing of the current page in the palette when its contents are changed.
• Problems with refreshing of the palette contents in Reader.
• Good luck.

[deyan]

Batch update from file query-obsoleted.csv