APP_COLOR_PICKER_R0

[Astea]

wiki page: APP_COLOR_PICKER_R0 - effort: 0.5d

[deyan]

Currently, there is an implementation in the pre-alpha, although some of the functionality there is not working. You can review it and see what can be improved. Probably, HSB and RGB being in one tab is better than the current implementation, but I like more current implementation of privew.

[deyan]

Batch update from file query-1.csv

[danvisel]

I rewrote this analysis at Jani's request.

[danvisel]

time = 4h.

[pap]

• I like your design.
• Perhaps you may show the ColorPicker as a panel in the hud.

[pap]

• Generally the implementation is done in a good manner and looks very good but there are some things that I cannot accept
• Huds are not supposed to have buttons as done and cancel on them. Sophie relies on direct model manipulation and the cancel should be provided by the undo some day. However this is a minor issue.
• There are lots of places where you use "new MyControl()" where the later is defined as s VisualElement and is registered to the visual elements extension point. You'd better use autoproperties for these controls that call the computeElementProp method.
• It this should also apply to the ColorHud and its picker. These properties should have @Own so that the parent-child relalationships are initialized properly.
• You can use these relationships for easier model manipulation througt the findParentElement method of BaseVisualElement class
• The color hud should be a kind of an advanced options sub-HUD of some other hud. So perhaps it will be nice to make a boundControl that shows sub-huds.
• Now it doesn't hide when the BackgoundAndBorderHud is hidden and this produces errors.
• I know that it is not your responsibilty to synchronize all code changes. But it will be nice if you can sinchronize your solution with the refactorig done that generalized the BoundColorField class
• The later three things may be considered somehow optional for this revision of the task if you find them too hard to implement.
• Also it may be nicer if the ColorPicker was a bit smaller as now you can see nothin

[pap]

adding cc

[jani]

Most notes taken into account.

[pap]

• The picker itself is nice but there are some things that were not well done
• The first is the beforementioned subhud thing.
• I did this by adding a subHud property of HudDialog an modifying HaloMenu#locationSynk to consider this property.
• The ColorPicker class still had some strange final properties. These were converted to auto proerties because they know how to compute themselves.
• There are still some problems with the internal organization of huds and subhuds that need to be improved.

[pap]

• Something very important tht is not achieved in this revision is that there should not be a different color picker for each component with adjustable color.

[danvisel]

I was going to say what Pap did - it's important for users to be able to use the same saved colors in the frame borders that they use in the frame fill. It does seem like the saved fill colors are shared between the page and frames, which is good.

[deyan]

Batch update from file query-obsoleted.csv