BASE_BOUND_CONTROLS_R1

[Astea]

wiki page: BASE_BOUND_CONTROLS_R1 - effort: 3d

[pap]

taken for analysis

[pap]

Finished analysis in 40m.

[pap]

Taken for design

[dido]

Almost there. The analysis is good but here is a list of problems in this analysis some of them are small other not so small:

• Missing goal - There should be some overview of the task that explains what this task is all about.
• Task requirements - hard to read actually, please format the wiki properly. Use sub bullets for sub list items instead of + sign
  • This line here - Change the hierarchy so that the icon of the state can be dropped (controls should be able to chose whether with such an icon or without it). I guess instead of dropped - optional will be more appropriate
  • This is not for this section - The listener should be attached not to the whole panel, but rather to the color rectangle which may become a "ButtonBoundControl".
• Implementation idea is empty - Lets mention the ideas in this section, not in requirements.
• Provide more detailed "How to demo" section. For example show the new controls in action or something.
• Please format the links in related section by putting each link in new line
• Finally if this is part of GROUP_GUI_REDESIGN_R0 shouldn't it include rescinning and customizing for all controls or it's not going to be implemented on this revision.

Analysis reviewed 2.5p (40m)

[velizar]

Reskinning is not part of this task.

[dido]

Analysis review 4p (20m)

[meddle]

I'm failing the task and postponing it for the next week.

• Now you can do that, write test and write tickets for these three bugs/tweak:
  • The JText bound fix
  • The Slider tweak
  • The ZOOM bug
• The next week this task will be yours and will have requirements like that (talk with tanya, me, pap and peko for details)
  • LogicR3 in all bounds.
  • Cleaner layout (think of a good design)
  • Fix ComboBox bound control
  • Remake the Spinner bound control
  • Think of more...

(1h)

[dido]

It's fine good luck.
Analysis reviewed 3.5p (30m)

[meddle]

I have the following notes:

• First of all write the tests for the Logic and the Combo
• ROW, COLUMN и SQUARE are ok, but you must be sure in their behavior... I mean ROW is different from FLOW, which must be added too(the current behavior is this -> FlowLayout). SQUARE must have an argument where to position the label (LEFT, RIGHT, CENTER). --Peko

2p (30m)

[meddle]

*"If validation for some group of bound controls is not necessary, the first member should be omitted." -> That's not true, In that case the first member -> PROCEED_VALIDATION will always declare the validation as successful but will be not omitted.

• There must be no "System.out"s in the code for review!
• You tried to have good tests, I'm happy :)

3.5p (20m)

[meddle]

You have two BIG problems:

• Your code could not be build with maven.
• You broke the combo box: BUG
  • on one frame open the background hud, choose to change the gradient background
  • Choose radial on the combo box... it changes.
  • On another frame pen the background hud, choose to change the gradient background
  • Choose radial on the combo box... it doesn't change and you can not change it in the future on no frame...

2p (30m)

[sveto]

(10h)

[meddle]

The bound controls don't work under the reader (try the zoom combo box)... So I'll fail this task...

2.5p (1h)

[sveto]

(3.5h)

[meddle]

I'll pass this task but I will not merge it to the trunk. In the future parts of it will be integrated to the redesign code...

• I don't like these sort keys, which are your fix for the reader.
• You had to fix all the bad code in the bounds' module and you didn't do it...
• The validation logic will stay as before when we integrate it, because there are some problems with the current implementation (you can write bound without writing validation logic and this approach leads to copy-paste code...)

3p (2h)

[deyan]

Batch update from file query-obsoleted.csv