s2s-login-functionality

[dido]

s2s-login-functionality

[todor]

• maybe it's nice to mention some limitations, like maximum image size (dimensions or kbs), password minimal length, session duration (if we have this), how the passwords will be reset.
• the rest of the analysis is pretty clear.

[dido]

We may consider remember me functionality.

[todor]

the new requirements fixed the problem with the easier accessibility and the lack of e-mail validation, however i'm not sure whether by default we must keep them on or off, maybe it is a good idea to discuss this with the developers or milo.

[dido]

Following task requirements are made optional after discussion with developers team

• (optional)ability to add additional emails
• (optional)should provide a way to manage visibility for user data
• (optional)upload image control - with description of size limitation

[todor]

i think, that the requirements are sufficient, i hope i didn't forget something again.

[meddle]

I understand that that is mainly WEB UI task, but the design is a little short in terms of code:

• First of all you have no design related code provided, neither link to the svn branch.
• Second I would like to describe some implementation ideas like:
  • What problems did you have with the mail API and their solutions.
  • The way the passwords are encrypted/decripted (You did'n update the section about that...)
  • The activation logic.
  • The configuration options listed
  • RegistrationFormBean -> what it has.
  • Describe the methods you put here : RequestHandlerUtil
• The login back button may be is good, but where is the submit one it is not mentioned...
• Names of the JSPs
• Handler paths for their handlers.
• CSS changes.
• I will be glad in the implementation phase to provide this kind of information, this is not just a task, it is documentation page.

3p

[meddle]

Code and implementation

• I like the way you improved the ConfigKey.
• You should add yourself as an author on classes you greatly modified as UserH for example.
• You should use "".equals(str) instead str.length == 0.
• Use ImmTreeList instead of NaiveImmList when creating empty lists. Later when you add something to it, the new immutable will be of the type of the empty list.
• Delete and not comment unused or obsolete tests.
• Why did you delete the Condition class, what was its purpose?
• Please when you see malformed JavaDoc, fix it. I like that you do it from time to time.
• Why didn't you document the RegistrationFormBean, its your responsibility now.
• Don't compare with strings with the mepty string with '==' or '!=', use 'equals'.

Usability

• when unexisting user requests password exception occurs
• e-mail verification is bad, can't we use already created solution
• is there a way to make e-mail not required when no e-mail verification is required (not so important)
• the default desciption should be empty, not "Write your description here"
• we may need to consider minimal length for the user name (not so important)

[meddle]

Merged into the trunk at [8982].

[meddle]

Closing all the tickets before M Y1