Ticket #2324 (closed bug: obsolete)
redesign align hud
| Reported by: | dido | Owned by: | dido |
|---|---|---|---|
| Priority: | major | Milestone: | X3 |
| Component: | ui_consistency | Version: | 2.0 |
| Keywords: | Cc: | dido | |
| Category: | unknown | Effort: | |
| Importance: | 70 | Ticket_group: | |
| Estimated Number of Hours: | 0 | Add Hours to Ticket: | 0 |
| Billable?: | yes | Total Hours: | 0 |
| Analysis_owners: | dido | Design_owners: | dido |
| Imp._owners: | dido | Test_owners: | |
| Analysis_reviewers: | deyan | Changelog: | Changelog |
| Design_reviewers: | pap | Imp._reviewers: | todor, pap |
| Test_reviewers: | Analysis_score: | 4 | |
| Design_score: | 3.5 | Imp._score: | 4 |
| Test_score: | 0 |
Attachments
Change History
comment:1 Changed 2 years ago by deyan
- Component changed from uncategorized to ui_consistency
- Milestone set to X3
comment:2 Changed 2 years ago by deyan
- Status changed from new to s1b_analysis_finished
Batch update from file active_tickets.csv
comment:4 Changed 2 years ago by deyan
- Analysis_reviewers set to deyan
- Analysis_owners set to dido
- Analysis_score changed from 0 to 4
comment:5 Changed 2 years ago by dido
- Status changed from s1b_analysis_finished to s2a_design_started
comment:6 Changed 2 years ago by dido
- Status changed from s2a_design_started to s2b_design_finished
- In order to skin all the alignment buttons the AlignElementsButton now extends LogicR3Button. The swing component is removed from this class and computeEvents method is overwritten.
- New skin is provided for all alignment buttons (AlignElementsBottom, AlignElementsHorizontaly, AlignElementsLeft, AlignElementsRight, AlignElementsTop and AlignElementsVerticaly), and their parent is no longer the AlignElementsHud.
- Inside AlignElementsHud are added two new children:
- The first one is title bar so it looks more consistent with other huds
- The second one is container for alignment buttons.
The code could be found in svn://sophie2.org/sophie2/branches/private/dido/alignHud2324
comment:8 Changed 2 years ago by pap
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 3.5
- Design_reviewers set to pap
- Ok but :
- Add yourself as an @author on a new line in the classes that you changed logically - the hud and the base class for the align buttons.
- Fix the JavaDoc of AlignButtonsContainer - description, empty line, @author
- The way the AlignButtonsContainer.swingComponent property is written is bad.
- Set the LayoutManager in the create method
- Set the visibility in the setup method
- Set the sub elements in the setupElements method
- Don't call validate and repaint for no reason
- The JavaDoc of AlignButtonsContainer.elements property is incorrect. You should have a description sentence and a @return part. The latter usually says "The property." or "Property." for methods returning props.
comment:9 Changed 2 years ago by dido
- Owner set to dido
- Status changed from s2c_design_ok to s3a_implementation_started
All comments from the design review are applied.
comment:10 Changed 2 years ago by dido
- Status changed from s3a_implementation_started to s3b_implementation_finished
- Imp._owners set to dido
comment:11 Changed 2 years ago by pap
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._score changed from 0 to 4
- Imp._reviewers set to todor, pap
- Commited in [9013].
- No remarks. We all like it.
comment:12 Changed 6 months ago by meddle
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Closing all the tickets before M Y1
Note: See
TracTickets for help on using
tickets.
Batch update from file query.csv