Ticket #2320 (closed bug: obsolete)

Opened 2 years ago

Last modified 2 months ago

browser frame URL must have two dots in it

Reported by: danvisel Owned by:
Priority: minor Milestone: X3
Component: uncategorized Version: 2.0
Keywords: Cc:
Ticket_group: Effort:
Category: unknown Importance: 70
Estimated Number of Hours: 0 Add Hours to Ticket: 0
Billable?: yes Total Hours: 0
Analysis_owners: danvisel Design_owners: deni
Imp._owners: deni Test_owners:
Design_reviewers: meddle Analysis_reviewers: deni
Changelog: Changelog Imp._reviewers: meddle, todor
Test_reviewers: Analysis_score: 4
Design_score: 4 Imp._score: 4
Test_score: 0

Description (last modified by danvisel) (diff)

1. Open Sophie.
2. Make a new book.
3. Insert a browser frame.
4. Click on the browser halo to open the browser HUD.
5. Try to enter the URL "http://sophie2.org"

Right now, URLs used in the browser need to have two dots - so " http://www.sophie2.org" would be fine and " http://dev.sophie2.org" would also be fine, but "http://sophie2.org" isn't allowed (even though that's a valid URL). I don't think we should be checking for this; this comes up during demos, where the temptation is to write a URL very quickly.

Attachments

browser-frame-url-validation.patch Download (0.7 KB) - added by deni 2 years ago.

Change History

Changed 2 years ago by danvisel

  • status changed from new to s1b_analysis_finished

Changed 2 years ago by danvisel

  • description modified (diff)

Changed 2 years ago by dido

  • importance set to 70

Changed 2 years ago by deni

  • design_owners set to deni
  • status changed from s1b_analysis_finished to s2a_design_started
  • implementation_owners set to deni
  • analysis_reviewers set to deni
  • changelog set to [wiki:Changelog]
  • analysis_score changed from 0 to 4

Changed 2 years ago by deni

Changed 2 years ago by deni

  • status changed from s2a_design_started to s3b_implementation_finished
  • I think we should change the regular expression for checking whether a String is a valid URL to the following: ".{3,}[.].{2,}", i.e. 3 or more characters followed by a . and then 2 or more characters.
  • It is very simple and accepts strings such as "example..com", but in this case it is better to allow an invalid value than to forbid a valid one.

Changed 2 years ago by meddle

  • status changed from s3b_implementation_finished to s3c_implementation_ok
  • design_score changed from 0 to 4
  • design_reviewers set to meddle
  • implementation_score changed from 0 to 4
  • implementation_reviewers set to meddle, todor

Merged on the trunk at [8717]. Good

Changed 2 months ago by meddle

  • status changed from s3c_implementation_ok to closed
  • resolution set to obsolete

Closing all the tickets before M Y1

Note: See TracTickets for help on using tickets.