Ticket #226 (closed planned_task: obsolete)
CORE_ADDITIONS_R0
| Reported by: | Astea | Owned by: | peko |
|---|---|---|---|
| Priority: | 3 | Milestone: | M02b_PRE2b |
| Component: | CORE_ADDITIONS | Version: | 2.0 |
| Keywords: | Cc: | ||
| Category: | unknown | Effort: | 3 |
| Importance: | 20 | Ticket_group: | |
| Estimated Number of Hours: | Add Hours to Ticket: | ||
| Billable?: | Total Hours: | ||
| Analysis_owners: | boyan | Design_owners: | peko |
| Imp._owners: | peko, peko, pav, peko, peko, peko | Test_owners: | |
| Analysis_reviewers: | Changelog: | ||
| Design_reviewers: | pap | Imp._reviewers: | boyan,pap,pap,gogov |
| Test_reviewers: | Analysis_score: | 3.5 | |
| Design_score: | 4 | Imp._score: | 4 |
| Test_score: | 0 |
Description
wiki page: CORE_ADDITIONS_R0 - effort: 3d
Change History
comment:1 Changed 17 years ago by boyan
- Owner changed from Astea to boyan
- Status changed from new to analyzing
comment:2 Changed 17 years ago by boyan
- Status changed from analyzing to analyzed
Analysis: Boyan (done: 40mins)
comment:3 Changed 17 years ago by pavlina
- Status changed from analyzed to new
2.5 by Pav. May be you mean org.sophie2.core module or what? The revision of the CORE and writing/running unit tests should be in the task requirements.
comment:5 Changed 17 years ago by boyan
- Status changed from analyzing to analyzed
Analysis2: Boyan (done: 15mins)
comment:6 Changed 17 years ago by pavlina
- Status changed from analyzed to analysis_accepted
3.5 by Pav. Good analysis.
comment:7 Changed 17 years ago by deyan
- Status changed from analysis_accepted to s1c_analysis_ok
repairing from invalid state
comment:8 Changed 16 years ago by deyan
- Milestone changed from M02_PRE2 to M02b_PRE2b
Milestone change
comment:9 Changed 16 years ago by boyan
- Design_score set to 0
- Test_score set to 0
- Imp._score set to 0
- Analysis_owners set to boyan,boyan
- Analysis_score set to 3.5
comment:10 Changed 16 years ago by peko
- Design_owners set to peko
- Owner changed from boyan to peko
- Status changed from s1c_analysis_ok to s2a_design_started
- Imp._owners set to peko
17h peko - done
comment:11 Changed 16 years ago by peko
- Status changed from s2a_design_started to s2b_design_finished
comment:12 Changed 16 years ago by pap
- Status changed from s2b_design_finished to s2c_design_ok
- Design_score changed from 0 to 4
- Design_reviewers set to pap
30m. Good job.
comment:13 Changed 16 years ago by peko
- Status changed from s2c_design_ok to s3a_implementation_started
comment:14 Changed 16 years ago by peko
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:16 Changed 16 years ago by boyan
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._score changed from 0 to 2
- Imp._reviewers set to boyan
In the implementation section you have to link to the changeset, as stated in PLATFORM_STANDARDS_GENERAL. Reviews are difficult to make with no link to the source code changed. Follow the standards!
comment:17 Changed 16 years ago by peko
- Status changed from s2c_design_ok to s3a_implementation_started
comment:18 Changed 16 years ago by peko
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:19 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._reviewers changed from boyan to boyan,pap
Things more to design:
- You should remove the second argument of the makeParentProp method. It used to be the ChildrenProperty ID but it's not needed anymore
- Deprecate the usage of ChildrenProperty
Things more to implementation:
- In ObjectProperty class, initOwnAnnotation method
- It is a good practice to put even single line if bodies in braces
- I think it would be better if you have "if(cond){do something} else {throw an exception}". This is line 344
- ListProperty class, initOwnAnnotation method
- You are logging at INFO level, while this information is DEBUG
- Same as with ObjectProperty about braces and throws
- FrameUnitTest is not good, but your changes there are a nonsense
- PageUnitTest has a parent().set() line, that shouldn't be such
- FrameFactory has a parent().set() line, that shouldn't be such
comment:20 Changed 16 years ago by pavlina
- Owner changed from peko to pavlina
- Status changed from s2c_design_ok to s3a_implementation_started
comment:21 Changed 16 years ago by pavlina
- Status changed from s3a_implementation_started to s3b_implementation_finished
- Imp._owners changed from peko to peko, peko, pav
40m
comment:22 Changed 16 years ago by pap
- Status changed from s3b_implementation_finished to s2c_design_ok
- Imp._reviewers changed from boyan,pap to boyan,pap,pap
What's done is a progress, but the tests don't verify this works with all kinds of properties. It was proved that there is a problem when using AutoListProperies.
You shoul write more tests especially when it is concerned to different property kinds.
comment:23 Changed 16 years ago by peko
- Category set to unknown
- Owner changed from pavlina to peko
- Status changed from s2c_design_ok to s3a_implementation_started
- Imp._owners changed from peko, peko, pav to peko, peko, pav, peko
comment:24 Changed 16 years ago by peko
- Status changed from s3a_implementation_started to s3b_implementation_finished
comment:25 Changed 16 years ago by peko
- Imp._owners changed from peko, peko, pav, peko to peko, peko, pav, peko, peko, peko
comment:26 Changed 16 years ago by gogov
- Status changed from s3b_implementation_finished to s3c_implementation_ok
- Imp._reviewers changed from boyan,pap,pap to boyan,pap,pap,gogov
comment:28 Changed 15 years ago by deyan
- Status changed from s3c_implementation_ok to closed
- Resolution set to obsolete
Batch update from file query-obsoleted.csv
Note: See
TracTickets for help on using
tickets.
