crash on previewing links

[danvisel]

Made a book of page 5 of the demo script. On clicking the Preview button (step 45), a crash happens, attached.

This doesn't happen if the book is saved before previewing, but then the links seem to be lost.

(This might be related to http://sophie2.org/trac/ticket/1710 but the bug report seems different.)

[danvisel]

crash on previewing links; zipped because of size.

[danvisel]

demo book for replicating error

[danvisel]

Easy way to replicate this: open "demo page 5v2.sjrb", select the "close" button, open the link HUD, add a link, make it hide frame 4. Then click "Preview": you get this crash.

[deni]

• The problem is that Link, LinkAction and all their subclasses don't follow the convention that every ProObject should have a constructor with a single ChangeManager argument.
• The necessary constructors will be added.
• LinkActionProvider's create method will have a ChangeManager parameter - the change manager responsible for the ActionLink-s the provider creates.
• In LinksHud when we create a new LinkAction, it should have an appropriate change manager - that of the hud's holder (frame or page)
• In Frame.link().compute() the new FrameLink should be created with the changeManager of the frame. The same applies for Page.link().compute().

[deni]

Changeset: [3916]

[mira]

Integrated in [3928] along with #1731, #1706.