Analysis

Overview

Enable easily writing of source code and tests (unit or system) with dialogs.

Task requirements

• Revise the existing source code for the dialogs.
• Define the extension points and the extensions connected with dialogs.
• Writing system tests with dialogs should be easy.

Task result

• The result of the task should be source code.

Implementation idea

-

Related

-

How to demo

• Run Sophie and show the dialogs.
• Run unit tests to demonstrate that it would be easy to use base dialogs with tests (unit or system).

Design

• The module org.sophie2.base.dialogs dialog module which extends sophie module, dialog object and dialog input(with settings to the dialog), dialog manager which controls the dialogs. We should remove the Activator class and use only the dialog module for activation.
• BaseDialogModule already provides extension point for the dialog extentions
• There is TestingDialogManager class. All dialog tests should use it, otherwise the automatic testing can break while the dialogs are shown.
• there is DialogManagerTest for the DialogManager but it is now in messy module. It should be moved in the test dir of base.dialogs and should not depends on file dialogs.

Implementation

Mock file and about dialogs for testing purposes created.
DialogManagerTest edited and moved to org.sophie2.base.dialogs.457
Javadoc fixed. 458

Testing

Comments

Log

Analysis: Tanya - done - 30m
Review: 3.5 by Pap.
Design:
Implementation:
Testing: